Skip to content

Upgrading PHP client to PHP 8 #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Upgrading PHP client to PHP 8 #74

wants to merge 1 commit into from

Conversation

vcampitelli
Copy link
Contributor

@vcampitelli vcampitelli commented Jan 23, 2024 •
edited
Loading

Some changes to the PHP Client to make it more consistent with PSR-12 coding rules and PHP 8.

@vcampitelli vcampitelli self-assigned this Jan 23, 2024
@vcampitelli vcampitelli requested a review from a team as a code owner January 23, 2024 18:48
@vcampitelli vcampitelli mentioned this pull request Jan 23, 2024
Merged
@mmanes mmanes deleted the branch main March 6, 2025 17:39
@mmanes mmanes closed this Mar 6, 2025
@mooreds mooreds reopened this Mar 7, 2025
@mooreds mooreds requested a review from a team as a code owner March 7, 2025 22:40
@mooreds
Copy link
Contributor

mooreds commented Mar 7, 2025

re-opened because I think we should support php 8 per @vcampitelli 's suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vcampitelli vcampitelli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vcampitelli @mooreds @mmanes