Skip to content

[CHORE] Null safety to 10 ui.charSelect classes #5118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

anysad
Copy link
Contributor

@anysad anysad commented May 20, 2025

Linked Issues

Contribution towards #4303

Description

This PR adds null-safety to the following classes:

  • ui.charSelect.CharacterUnlockState
  • ui.charSelect.CharIcon
  • ui.charSelect.CharIconCharacter
  • ui.charSelect.CharIconLocked
  • ui.charSelect.CharSelectGF
  • ui.charSelect.CharSelectPlayer
  • ui.charSelect.CharSelectSubState (PARTIAL)
  • ui.charSelect.IntroSubState (PARTIAL)
  • ui.charSelect.Lock
  • ui.charSelect.Nametag

@github-actions github-actions bot added pr: haxe PR modifies game code. status: pending triage Awaiting review. size: large A large pull request with more than 100 changes. labels May 20, 2025
@anysad
Copy link
Contributor Author

anysad commented May 20, 2025

gosh I hate my browser

@anysad anysad changed the base branch from main to develop May 20, 2025 14:01
@anysad anysad changed the title Null safety charselect [CHORE] Null safety to 10 ui.charSelect classes May 20, 2025
@Hundrec Hundrec added the type: chore Involves minor adjustments that do not make functional changes. label May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: haxe PR modifies game code. size: large A large pull request with more than 100 changes. status: pending triage Awaiting review. type: chore Involves minor adjustments that do not make functional changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants