Skip to content

Added "SongScore" class #5114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Added "SongScore" class #5114

wants to merge 2 commits into from

Conversation

An-enderman
Copy link
Contributor

moved the "songScore" variable to it's own class called "SongScore"

I made this because it's a to-do

I also added the Void return type to the "applyScore" function because the function didn't have a specified return type

@An-enderman
Added "SongScore" class
e7398fe 
moves the songScore variabe to it's own class
@github-actions github-actions bot added status: pending triage Awaiting review. size: medium A medium pull request with 100 or fewer changes. pr: haxe PR modifies game code. and removed size: medium A medium pull request with 100 or fewer changes. labels May 19, 2025
@Hundrec Hundrec added type: enhancement Involves an enhancement or new feature. size: medium A medium pull request with 100 or fewer changes. labels May 19, 2025
@AbnormalPoof
Copy link
Collaborator

I feel like this can be a singleton with an instance variable due to the nature of the class.

CrusherNotDrip
CrusherNotDrip approved these changes May 20, 2025
View reviewed changes
Copy link
Contributor

@CrusherNotDrip CrusherNotDrip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

holy jeepers creepers an enderman picked up the score blocked and teleport it to a new class!

@An-enderman
minor update
f848611 
added some documentation and imported "SongScore" in PlayState
@An-enderman
Copy link
Contributor Author

added some documentation and imported "SongScore" in PlayState

@An-enderman
Copy link
Contributor Author

If this gets eventually merged, how much time am I gonna be waiting before that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CrusherNotDrip CrusherNotDrip CrusherNotDrip approved these changes

Assignees
No one assigned
Labels
pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. status: pending triage Awaiting review. type: enhancement Involves an enhancement or new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@An-enderman @AbnormalPoof @CrusherNotDrip @Hundrec