Skip to content

[BUGFIX] Sing animations not ignored when animation is forced #5110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Lasercar
Copy link
Contributor

@Lasercar Lasercar commented May 18, 2025

Linked Issues

Fixes #3491

Description

Animations starting with sing are not ignored when an animation is forced for a character.

Screenshots/Videos

Before change:

2025-05-21.10-50-23.mp4

After change:

2025-05-21.10-49-21.mp4

@Lasercar Lasercar changed the base branch from main to develop May 18, 2025 11:18
@github-actions github-actions bot added status: pending triage Awaiting review. pr: haxe PR modifies game code. size: tiny A tiny pull request with 4 or fewer changes. labels May 18, 2025
@AbnormalPoof AbnormalPoof added the type: minor bug Involves a minor bug or issue. label May 18, 2025
@Hundrec
Copy link
Collaborator

Hundrec commented May 18, 2025

This might re-introduce bugs where animation events override later singing animations.
Have you tested to make sure later notes still play their animations?

@Lasercar
Copy link
Contributor Author

This might re-introduce bugs where animation events override later singing animations. Have you tested to make sure later notes still play their animations?

No, as far as I'm concerned, forcing an animation will now also prevent singing animations from playing until the forced animation finishes (unless someone adds sing to the ignoreExclusionPref, in a character's script or otherwise).

@Hundrec Hundrec added status: needs revision Cannot be approved because it is awaiting some work by the contributor. and removed status: pending triage Awaiting review. labels May 20, 2025
@Hundrec
Copy link
Collaborator

Hundrec commented May 20, 2025

Changes that re-introduce previously fixed bugs won't be accepted. Please find a different method, such as implementing a layered animation priority system.

@Hundrec Hundrec closed this May 21, 2025
@Hundrec Hundrec added status: rejected Issue did not pass review or PR cannot be approved. and removed status: needs revision Cannot be approved because it is awaiting some work by the contributor. type: minor bug Involves a minor bug or issue. pr: haxe PR modifies game code. labels May 21, 2025
@Hundrec
Copy link
Collaborator

Hundrec commented May 21, 2025

Closing this PR because it re-introduces a bug: #2367.

@Lasercar
Copy link
Contributor Author

Lasercar commented May 21, 2025

Hmm, I've got an idea for fixing the root issue, though it'll require a few changes to the scripts in the assets.

nvm, #5123
is what I basically had in mind, but way better.

@Lasercar Lasercar deleted the bugfix/sing-animations-not-ignored-when-animation-is-forced branch May 21, 2025 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: tiny A tiny pull request with 4 or fewer changes. status: rejected Issue did not pass review or PR cannot be approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report: Forced Animations not overwriting note animations
3 participants