[BUGFIX] Fix LatencyState cleanup not being performed in hot-reload #5085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
status: pending triage
NotHyper-474
force-pushed
the
bugfix/hot-reload-latencystate-crash-fix
branch
from
21c4b4b to
d525a5d
Compare
AbnormalPoof
added
type: major bug
EliteMasterEric
added
the
size: tiny
AbnormalPoof
removed
the
size: small
EliteMasterEric
added
size: small
…d by state switch
NotHyper-474
force-pushed
the
bugfix/hot-reload-latencystate-crash-fix
branch
from
d525a5d to
a200d65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues
Fixes the NOR in #4252 (please make two different things two separate issues ok thx)
Description
The
closefunction was never being called by anything so in some casescleanupwould never run and cause an error.But
destroyon the other hand can be relied on, so this fixes this by simply replacingclosewith it.(Not sure why someone would run hot-reload in the input offsets state though... oh wait, this also happens if you press F4 since there's also a state switch, so valid issue I guess)
Screenshots/Videos
N/A
guhh i can't be bothered to make a video for this fix