Handle no grounding responses better ai 1697#6
Merged
Conversation
nmenezes0
approved these changes
Feb 27, 2026
nmenezes0
left a comment
There was a problem hiding this comment.
Looks good - nice clear function names so I think I managed to follow!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes AI-1697.
Currently we ask Gemini to do grounding a grounding Google search. If it doesn't do that search, we will still return the output.
This change makes it so that if Gemini doesn't do that search, we raise an exception.
Practically, this will mean that SIFT should stop showing results with made up URLs. It will also mean that for an unknown number of claims we may not get any results, but we've decided that's probably better than potentially having lots of hallucinated sources.
There's also some improvements to test coverage, at the end of
test_gemini.py. They're fairly uncontroversial, but there were various things I wanted to check to make sure this new exception didn't change behaviour in unexpected ways.Pull request checklist
main