Skip to content

add possibility to use a callback function as naming attribute for images#1000

Open
ckilb wants to merge 24 commits intoFrozenNode:devfrom
ckilb:master
Open

add possibility to use a callback function as naming attribute for images#1000
ckilb wants to merge 24 commits intoFrozenNode:devfrom
ckilb:master

Conversation

@ckilb
Copy link
Copy Markdown

@ckilb ckilb commented Mar 17, 2016

No description provided.

@ckilb
Copy link
Copy Markdown
Author

ckilb commented Mar 17, 2016

This pull requests makes it possible to use a callback function for the naming option for images ("keep" vs callback function vs anything else for random).
For this I've moved the logic for generating random file names from the Multup class into the File.php class. I think it would be a good idea to get completely rid of the Multup class :) Like you said in one of the commits, it's a disaster ;)
I wasn't sure if the file name generation still should belong to the File Field class. But I think it's still fine to have this being part of the responsibility for this class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant