[TASK] Refactor command input handling and remove redundant validators#197
[TASK] Refactor command input handling and remove redundant validators#197
Conversation
The Decorators no longer instantiate Normalizers to avoid duplicate work. Specialized validators (Command, Controller, Event, etc.) have been removed in favor of calling ClassNameValidator directly. Since the Normalizer now ensures the correct suffixes are present before validation occurs, the suffix-specific checks are no longer required.
|
Relates to PR: #171 |
simonschaufi
left a comment
simonschaufi
left a comment
There was a problem hiding this comment.
I like your improvements!
|
@simonschaufi Thank you, but be careful. Now, the default value for various classname questions is just "DoSomething" and not "DoSomethingCommand" anymore. I don't think that this is an issue. Nevertheless the "Command" will automatically be applied, if not already given...but hidden for the user. Only with last confirmation the user will see, that we have added the "needed" suffix to the class- and filename. What do you think? Still OK? |
That is absolutely fine for me. |
|
I hope you will also add some tests later on 😄 |
|
I have written you via Slack |
|
I just started writing tests. Happy review ;-) |
2 participants
The Decorators no longer instantiate Normalizers to avoid duplicate work. Specialized validators (Command, Controller, Event, etc.) have been removed in favor of calling ClassNameValidator directly.
Since the Normalizer now ensures the correct suffixes are present before validation occurs, the suffix-specific checks are no longer required.