Skip to content

Conversation

floviolleau
Copy link

@floviolleau floviolleau commented Feb 10, 2024

Q A
Bug fix? no
New feature? yes
BC breaks? yes
Deprecations? yes
Fixed tickets N/A
License MIT

Hi,

This is a full rewrite to make it working with ckeditor 5.
Because I still use Symfony 5.4 and Php 7.4, I allowed to install with Php 7.4

Here is an example of configuration:

# Read the documentation: https://symfony.com/doc/current/bundles/FOSCKEditorBundle/index.html
twig:
    form_themes:
        - '@FOSCKEditor/Form/ckeditor_widget.html.twig'

fos_ck_editor:
    default_config: classic_config
    powered_by: false
    configs:
        balloon_config:
            build: 'balloon'
            toolbar: { items: ['bold', 'italic', 'bulletedList', 'link' ] }
        classic_config:
            build: 'classic'
            minHeight: '212px'
#            width: '50px'
#            licenseKey: 'your-license-key',
            toolbar: { items: ['undo', 'redo', '|', 'bold', 'italic', 'bulletedList', 'link' ] }
#            ui: { poweredBy: { position: 'inside', side: 'right', label: '' } }
#            extraPlugins: ['ResizableHeight']
#            ResizableHeight: {
#                resize: false,
#                height: '500px',
#                minHeight: '100px',
#                maxHeight: '1000px'
#            }
#            style: {
#                definitions: [
#                    {
#                        name: 'Article category',
#                        element: 'h3',
#                        classes: [ 'category' ]
#                    },
#                    {
#                        name: 'Info box',
#                        element: 'p',
#                        classes: [ 'info-box' ]
#                    },
#                ]
#            }
#            template: {
#                definitions: [
#                    {
#                        title: 'The title of the template',
#                        description: 'A longer description of the template',
#                        data: '<p>Data inserted into the content</p>'
#                    }
#                ]
#            }
    styles: { '.ck.ck-editor__editable': { 'background-color': 'red' }

#    plugins:
#        ResizableHeight:
#            path: '/bundles/ckeditor5-resizableheight/'
#            filename: 'plugin.js'

Remaining tasks:

@Nek-
Copy link
Contributor

Nek- commented May 14, 2024

Related issue: #242

@Chris53897
Copy link
Contributor

@floviolleau Thanks for working on this. Could you please resolve the conflicts and give us an update of your plans (remaining tasks) ?

@floviolleau
Copy link
Author

Hi @Chris53897,

I fixed the conflicts.

The remaining tasks are in the first message and still pending.

I have a basic usage of ckeditor5 so for now I didn't implemented plugins and other stuffs.

My PR is still pending since last year, nobody maintain this project so I implement what I need for now :).

Feel free to enhance my MR.

I made #272 for php8

@Nek-
Copy link
Contributor

Nek- commented Aug 28, 2025

This PR really scares me regarding #242 (comment)

Would it be possible to make ckeditor5 optional?

@floviolleau
Copy link
Author

Hi,

Ckeditor is OK if your are on GPL.

Make ckeditor5 optional is some work because logic to retrieve and do configuration is different as well the rendering.

I will think about it but it can be better if the maintainer is still here to guide developments and at least approve PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants