This repository has been archived by the owner on Nov 9, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick solution to #3
A couple of thoughts:
any
type. Ideally with a bit of Typescript voodoo one could make so thatMagnifyManager.engine
returns the type of the specific engine instead of the abstractMagnifyEngine
and this should solve the problem with the getter type as well (also the client getter does not need to be part of the abstractMagnifyEngine
)magnify
service was not exported. Should we also change the filename frommagnify.ts
tomain.ts
as in most of other AdonisJS packages