fix[RL78 Port] incorrect register image for pvParameters in FAR mode (#1316) #1317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…FreeRTOS#1316) In the RL78 FAR data model, pxPortInitialiseStack() did not correctly initialize the register image for the task parameter (pvParameters). The saved A:DE registers were filled with dummy values instead of the actual pointer value. As a result, when the first context restore occurred, the compiler's function prologue read a corrupted parameter from the register image. This only affected FAR builds; NEAR model was not impacted. This patch updates the RL78 FAR path so that the register image matches the calling convention: - DE = low 16 bits of pvParameters - A = high 8 bits of pvParameters (via AX register image, X = 0) With this change, tasks in FAR model receive the correct parameter at entry, while NEAR model remains unchanged.
|
@KeitaKashima What do you think about this change? |
|
@aggarg san
My team will check the code. Could you please have some time to check it in about one or two weeks? |
|
@KeitaKashima Of course. Take your time. Thank you for your help with the review! |
|
@aggarg @TakeoTakahashi2020 and @ShunichiroNakamura of my team members, will check and answer the result. |
|
@KeitaKashima No worries at all! Please take your time. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
fix[RL78 Port] incorrect register image for pvParameters in FAR mode (#1316)
Description
In the RL78 FAR data model, pxPortInitialiseStack() did not correctly
initialize the register image in the task stack for the parameter (pvParameters).
The saved A:DE registers were filled with dummy values instead of the actual pointer value.
As a result, when the first context restore occurred, the compiler's function prologue read a corrupted parameter from the register image.
This only affected FAR builds; NEAR model was not impacted.
This patch updates the RL78 FAR path so that the register image matches the RL78 calling convention:
DE = low 16 bits of pvParameters
A = high 8 bits of pvParameters (via AX register image, X = 0)
With this change, tasks in FAR model receive the correct parameter at entry, while NEAR model remains unchanged.
Test Steps
Before fix: value corrupted (dummy registers A:DE = 0x1111/0xDEDE).
After fix: value matches the pointer passed to xTaskCreate.
Confirm no regression with NEAR model build.
Checklist
I have tested my changes. No regression in existing tests.
I have modified and/or added unit-tests to cover the code changes in this Pull Request.
Related Issue
#1316