Disable stack overflow check for MPU ports #1231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stack overflow check is not straight forward to implement for MPU ports because of the following reasons: 1. The context is stroed in TCB and as a result, pxTopOfStack member points to the context location in TCB. 2. System calls are executed on a separate privileged only stack. It is still okay because an MPU region is used to protect task stack which means task stack overflow will trigger an MPU fault. Signed-off-by: Gaurav Aggarwal <[email protected]>
kar-rahul-aws
previously approved these changes
Jan 31, 2025
tony-josi-aws
previously approved these changes
Jan 31, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1231 +/- ##
==========================================
+ Coverage 91.64% 91.65% +0.01%
==========================================
Files 6 6
Lines 3254 3259 +5
Branches 903 901 -2
==========================================
+ Hits 2982 2987 +5
Misses 132 132
Partials 140 140
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Gaurav Aggarwal <[email protected]>
aggarg
dismissed stale reviews from tony-josi-aws and kar-rahul-aws
via
2feb8bd
|
tony-josi-aws
approved these changes
Feb 24, 2025
kar-rahul-aws
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Stack overflow check is not straight forward to implement for MPU ports because of the following reasons:
It is still okay because an MPU region is used to protect task stack which means task stack overflow will trigger an MPU fault.
Test Steps
Verified on Cortex-M33 hardware.
Checklist:
Related Issue
#1195
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.