Modernization of CDR

[danardf]

I modernized this old module which was ugly for a long time ago. Now it looks better.

[chrsmj]

This appears to be AI-generated and contains multiple potential SQL injection errors.

[danardf]

@chrsmj
Hi.
Yes, I played with Claude 4 for fun. I don't hide this fact. I wanted to test it and see if that was correct to use it. ;)

Can you give me an example just to check?

It's just to see if claude is able to fixe it.
I saw some issue with a direct injection too.

[chrsmj]

No I am not going to debug your AI generated code.

[danardf]

Well. As you like.
"I know there is a bug, but I don't want to help you."
That's your mindset. I see you are nice, indeed.
Whatever. I saw some. Don't worry. ;)

[chrsmj]

Are there any unit tests being added ?

[mrpbueno]

Hey @danardf , just a quick pointer on the SQL injection topic. Check out how $_REQUEST['sort'] is used to build the ORDER BY clause in the new getCdrData function. Directly using request parameters in that part of a query is a common risk. A whitelist for allowed column names is usually the safest approach there. Hope that's a helpful starting point!

[danardf]

@mrpbueno hi
Yes I know. I saw that. indeed.
I did not review the code after generating by I.A, That's it.
I just trust on it. But I should not indeed.

[blazestudios97]

This appears to be AI-generated and contains multiple potential SQL injection errors.

Interestingly, the current Cdr.class.php has the same SQL injection issues, AI didn't seem to create those Franck just used what already existed. So kudos you just discovered existing SQL injection issues in the CDR module.

[danardf]

I think it's fixed now
I hope I've fixed everything out.

[danardf]

Hi
Feel free to review guys.

[danardf]

@kguptasangoma Hi
No way to be tested?

[kguptasangoma]

Hi @danardf did not get chance to look into this one. Needs to kick off the QA also.

Thanks
Kapil

[danardf]

@kguptasangoma Ok update me asap. please.

[kguptasangoma]

May be we can ask community help also to test the PR.

[danardf]

As you want.
Lorne tested it quickly, and looks good for him. Just need to test further