Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mutltiple Fixes #674

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Mutltiple Fixes #674

wants to merge 7 commits into from
+86 −35

Conversation

ferdinandjarisch
Copy link
Contributor

See individual commit messages

@ferdinandjarisch
fix(log): Remove seemingly out-of-place setup_logging call
70cec3e
@ferdinandjarisch
feat(log): Show all logs using python's logging package on CLI
9cea869
@ferdinandjarisch
fix(log): Properly let -v CLI flag increase log level
ae27580
@ferdinandjarisch
fix(log): Properly terminate log listeners and handlers
8756f65 
Fixes #641 by closing all created log listeners and handlers before
returning from the entry_point.
@ferdinandjarisch
fix(multiple): Properly propagate unclean scans and return with error
007c87e 
While the encountered errors are deemed important enough to abort the
remaining scan in a session, the scanner finishes with exit code 0.
This change properly propagates these cases and returns a non-zero error
code to better indicate unclean scans.
@ferdinandjarisch
chore(log): Further reduce log level of dying tasks
e758d45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumpelsepp rumpelsepp Awaiting requested review from rumpelsepp rumpelsepp is a code owner

@peckto peckto Awaiting requested review from peckto peckto is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ferdinandjarisch