Make maximum dynamic pressure for deployable radiators configurable.#55
Open
bfrobin446 wants to merge 10 commits intoFractalUK:developfrom
Open
Make maximum dynamic pressure for deployable radiators configurable.#55bfrobin446 wants to merge 10 commits intoFractalUK:developfrom
bfrobin446 wants to merge 10 commits intoFractalUK:developfrom
Conversation
Relocated the code to prevent deployment if the radiator will break from DeployRadiatorAction into DeployRadiator.
Pick up changes from upstream between completing the radiator dynamic-pressure work and attacking anything else.
Revert "Added contents of GameData/OpenResourceSystem." This reverts commit b6a7f7c.
Revert "Modified project files for local build." This reverts commit 2efe961.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One poster on the forum thread asked for deployable radiators to break less abruptly in atmosphere. The current maximum dynamic pressure seems OK to me, but I moved it from a hard-coded constant in the plugin to a
maxQentry in the part's .cfg.I also added code to prevent a retracted radiator from deploying if it would immediately break.