Skip to content

Deprecate compiled statement continuations in jdbc #3659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −6
Open

Deprecate compiled statement continuations in jdbc #3659

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions fdb-relational-grpc/src/main/java/com/apple/foundationdb/relational/jdbc/TypeConversion.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -581,8 +581,6 @@ public static Continuation.Reason toReason(RpcContinuationReason reason) {
@SuppressWarnings("unchecked")
static com.apple.foundationdb.relational.jdbc.grpc.v1.Options.Builder toProtobuf(@Nonnull Options options) throws SQLException {
final var builder = com.apple.foundationdb.relational.jdbc.grpc.v1.Options.newBuilder();
// Switched-on by default on JDBC driver until the option is deprecated and removed.
builder.setContinuationsContainCompiledStatements(true);
for (Map.Entry<Options.Name, ?> entry : options.entries()) {
switch (entry.getKey()) {
case MAX_ROWS:
Expand Down Expand Up @@ -802,9 +800,6 @@ public static Options fromProtobuf(com.apple.foundationdb.relational.jdbc.grpc.v
if (protoOptions.hasValidPlanHashModes()) {
builder.withOption(Options.Name.VALID_PLAN_HASH_MODES, protoOptions.getValidPlanHashModes());
}
if (protoOptions.hasContinuationsContainCompiledStatements() && !protoOptions.getContinuationsContainCompiledStatements()) {
throw new RelationalException("Option CONTINUATIONS_CONTAIN_COMPILED_STATEMENTS=false not supported anymore!", ErrorCode.UNSUPPORTED_OPERATION).toUncheckedWrappedException();
}
if (protoOptions.hasAsyncOperationsTimeoutMillis()) {
builder.withOption(Options.Name.ASYNC_OPERATIONS_TIMEOUT_MILLIS, protoOptions.getAsyncOperationsTimeoutMillis());
}
Expand Down
2 changes: 1 addition & 1 deletion fdb-relational-grpc/src/main/proto/grpc/relational/jdbc/v1/jdbc.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ message Options {
optional bool case_sensitive_identifiers = 22;
optional string current_plan_hash_mode = 23;
optional string valid_plan_hash_modes = 24;
optional bool continuations_contain_compiled_statements = 25;
optional bool continuations_contain_compiled_statements = 25 [deprecated = true];
optional int64 async_operations_timeout_millis = 26;
optional bool encrypt_when_serializing = 27;
optional string encryption_key_store = 28;
Expand Down
Loading