Changes for EXPLAIN VERBOSE #3564
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit for Issue 3028
…sitFullDescribeStatement
…s plan structure instead of verbose plans
…ExplainConfig decorates the query with EXPLAIN. To add tests for EXPLAIN VERBOSE, we should add another config (ExplainVerboseConfig) and decorate the query with EXPLAIN VERBOSE. The test block should also be extendended to support explainVerbose:.
…ExplainConfig decorates the query with EXPLAIN. To add tests for EXPLAIN VERBOSE, we should add another config (ExplainVerboseConfig) and decorate the query with EXPLAIN VERBOSE. The test block should also be extendended to support explainVerbose:.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hatyo Please review at your convenience.
I made changes to the tests, especially to yaml-tests so that the plan output is what would be output for EXPLAIN (not VERBOSE). I did it this way because ExplainConfig decorates the query in the test block with “EXPLAIN”. We should think of adding an ExplainVerboseConfig that could decorate the query with “EXPLAIN VERBOSE” and enhance test blocks to support “explainVerbose” in addition to “explain” and “explainContains”.