Fixes #3259: Prepare to upgrade to Protobuf 4. #3260
+7
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Address some small incompatibilities between Protobuf 3 and Protobuf 4, attempting to have code that will compile against both. * `Descriptors.FileDescriptor.getSyntax`, which was deprecated, is now removed. Use `DescriptorProtos.FileDescriptorProto.getSyntax`. * `TextFormat.shortDebugString` is deprecated. Remove newlines manually for now (only in test failure codepath). * guava is no longer a transitive dependency; add it explicitly where needed.
|
See also #3258. That one seems to hit a problem where the syntax field isn't picked up correctly in the file descriptor, and I'm not sure what we'd want to do about it |
alecgrieser
approved these changes
Mar 19, 2025
|
#3261 seems to have passed tests; is that unexpected based on the other one? Is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address some small incompatibilities between Protobuf 3 and Protobuf 4, attempting to have code that will compile against both.
Descriptors.FileDescriptor.getSyntax, which was deprecated, is now removed. UseDescriptorProtos.FileDescriptorProto.getSyntax.TextFormat.shortDebugStringis deprecated. Remove newlines manually for now (only in test failure codepath).