Allow specifying a custom cluster file to FRL and YamlTestExtension #3251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows running yamsql tests with a custom cluster file that is not specified via the environment variable. This doesn't add support for doing this with the @yamltest annotation.
This is ok, it will get it from the environment variable if it is null, but we can't set the environment variable to null.
ScottDugas
changed the title
alecgrieser
approved these changes
Mar 17, 2025
ScottDugas
added a commit
to ScottDugas/fdb-record-layer
that referenced
this pull request
Mar 17, 2025
When publishing to JUnit xml style files there is no hierarchy, so
some tools will just show the class name and description, making it
hard to tell what tests were run, or failed. If YamlTestExtension
is used in an environment where that is the case this can be used
to have the output include the method name. For example:
- showcasingTests(Embedded)
- showcasingTests(MultiServer (Embedded then !current_version))
...
Instead of
- YamlIntegrationTests
- showcasingTests(Runner)
- Embedded
- MultiServer (Embedded then !current_version)
I thought about making this configurable via system property, but
I think having it configured by a constructor parameter aligns more
with PRs FoundationDB#3252 and FoundationDB#3251
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows running yamsql tests with a custom cluster file that is not specified via the environment variable.
This doesn't add support for doing this with the
@YamlTestannotation.