Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing explicit dependencies for gradle tasks #3250

Merged
merged 1 commit into from
Mar 17, 2025

Conversation

ScottDugas
Copy link
Collaborator

The JMH one is a little surprising to me, as that is just a plugin.

I basically just followed what gradle printed in the warnings. Also, I validated this locally running each task with a clean, e.g. ./gradlew clean :fdb-relational-cli:jar --warning-mode all on main, it fails because files don't exst, but on this branch they succeed.

This is part of the work to allow upgrading to gradle 8: #3242

The JMH one is a little surprising to me, as that is just a plugin.

I basically just followed what gradle printed in the warnings.
Also, I validated this locally running each task with a clean, e.g.
./gradlew clean :fdb-relational-cli:jar --warning-mode all
on main, it fails because files don't exst, but on this branch they
succeed.
@ScottDugas ScottDugas added the build improvement Improvement to the build system label Mar 17, 2025
@ScottDugas ScottDugas requested a review from alecgrieser March 17, 2025 15:00
@ScottDugas ScottDugas merged commit 15853e5 into FoundationDB:main Mar 17, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build improvement Improvement to the build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants