Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Gradle 8 #3242

Open
ScottDugas opened this issue Mar 11, 2025 · 1 comment
Open

Upgrade to Gradle 8 #3242

ScottDugas opened this issue Mar 11, 2025 · 1 comment
Assignees
@ScottDugas

Comments

@ScottDugas
Copy link
Collaborator

We should upgrade to using the latest gradle.
@ScottDugas ScottDugas self-assigned this Mar 11, 2025
ScottDugas added a commit to ScottDugas/fdb-record-layer that referenced this issue Mar 11, 2025
@ScottDugas
Add --warning-mode all to all our builds
efce7bb 
I have done this for prb, and fixed the issues it found, now
we need to expand it to other jobs, namely nightly and release.

This is part of the work to upgrade to gradle 8: FoundationDB#3242
@ScottDugas ScottDugas mentioned this issue Mar 11, 2025
Merged
alecgrieser pushed a commit that referenced this issue Mar 13, 2025
@ScottDugas
Add --warning-mode all to all our builds (#3243)
1076496 
I have done this for prb, and fixed the issues it found, now we need to
expand it to other jobs, namely nightly and release.

This is part of the work to upgrade to gradle 8: #3242
@ScottDugas
Copy link
Collaborator Author

I'm seeing these warnings:

> Task :fdb-record-layer-jmh:generateJmhProto
Execution optimizations have been disabled for task ':fdb-record-layer-jmh:generateJmhProto' to ensure correctness due to the following reasons:
  - Gradle detected a problem with the following location: '/home/runner/work/fdb-record-layer/fdb-record-layer/fdb-record-layer-jmh/.out/extracted-include-protos/main'. Reason: Task ':fdb-record-layer-jmh:generateJmhProto' uses this output of task ':fdb-record-layer-jmh:extractIncludeProto' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.6.4/userguide/validation_problems.html#implicit_dependency for more details about this problem.
Gradle detected a problem with the following location: '/home/runner/work/fdb-record-layer/fdb-record-layer/fdb-record-layer-jmh/.out/extracted-include-protos/main'. Reason: Task ':fdb-record-layer-jmh:generateJmhProto' uses this output of task ':fdb-record-layer-jmh:extractIncludeProto' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. This behaviour has been deprecated and is scheduled to be removed in Gradle 8.0. Execution optimizations are disabled to ensure correctness. See https://docs.gradle.org/7.6.4/userguide/validation_problems.html#implicit_dependency for more details.
> Task :fdb-relational-cli:jar
Execution optimizations have been disabled for task ':fdb-relational-cli:jar' to ensure correctness due to the following reasons:
  - Gradle detected a problem with the following location: '/home/runner/work/fdb-record-layer/fdb-record-layer/fdb-record-layer-core/.out/libs/fdb-record-layer-core-4.1.9.0.jar'. Reason: Task ':fdb-relational-cli:jar' uses this output of task ':fdb-record-layer-core:jar' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.6.4/userguide/validation_problems.html#implicit_dependency for more details about this problem.
  - Gradle detected a problem with the following location: '/home/runner/work/fdb-record-layer/fdb-record-layer/fdb-extensions/.out/libs/fdb-extensions-4.1.9.0.jar'. Reason: Task ':fdb-relational-cli:jar' uses this output of task ':fdb-extensions:jar' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.6.4/userguide/validation_problems.html#implicit_dependency for more details about this problem.
Gradle detected a problem with the following location: '/home/runner/work/fdb-record-layer/fdb-record-layer/fdb-record-layer-core/.out/libs/fdb-record-layer-core-4.1.9.0.jar'. Reason: Task ':fdb-relational-cli:jar' uses this output of task ':fdb-record-layer-core:jar' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. This behaviour has been deprecated and is scheduled to be removed in Gradle 8.0. Execution optimizations are disabled to ensure correctness. See https://docs.gradle.org/7.6.4/userguide/validation_problems.html#implicit_dependency for more details.
Gradle detected a problem with the following location: '/home/runner/work/fdb-record-layer/fdb-record-layer/fdb-extensions/.out/libs/fdb-extensions-4.1.9.0.jar'. Reason: Task ':fdb-relational-cli:jar' uses this output of task ':fdb-extensions:jar' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. This behaviour has been deprecated and is scheduled to be removed in Gradle 8.0. Execution optimizations are disabled to ensure correctness. See https://docs.gradle.org/7.6.4/userguide/validation_problems.html#implicit_dependency for more details.

I also see warnings about -Xverify:none, which is being resolved with: #3244

@ScottDugas ScottDugas mentioned this issue Mar 17, 2025
Merged
ScottDugas added a commit that referenced this issue Mar 17, 2025
@ScottDugas
Add missing explicit dependencies for gradle tasks (#3250)
15853e5 
The JMH one is a little surprising to me, as that is just a plugin.

I basically just followed what gradle printed in the warnings. Also, I
validated this locally running each task with a clean, e.g. ./gradlew
clean :fdb-relational-cli:jar --warning-mode all on main, it fails
because files don't exst, but on this branch they succeed.

This is part of the work to allow upgrading to gradle 8:
#3242
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ScottDugas ScottDugas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ScottDugas