Sdks 4616 journey sample app #84
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ture branch the dependency that supports those changes
george-bafaloukas-forgerock
requested review from
rodrigoareis,
spetrov and
vahancouver
spetrov
requested changes
Jan 7, 2026
Contributor
spetrov
left a comment
spetrov
left a comment
There was a problem hiding this comment.
LGTM, but you may want to take a look and address my comments.
iOS/swiftui-journey-module/JourneyModuleSample/JourneyModuleSample.xcodeproj/project.pbxproj
Outdated
Show resolved
Hide resolved
...ney-module/JourneyModuleSample/JourneyModuleSample/Callbacks/DeviceBindingCallbackView.swift
Show resolved
Hide resolved
...ui-journey-module/JourneyModuleSample/JourneyModuleSample/Callbacks/CustomPinCollector.swift
Show resolved
Hide resolved
...le/JourneyModuleSample/JourneyModuleSample/Callbacks/DeviceSigningVerifierCallbackView.swift
Show resolved
Hide resolved
rodrigoareis
requested changes
Jan 8, 2026
| * during the collection process. The component handles the entire lifecycle of device profile | ||
| * collection without requiring user interaction. | ||
| */ | ||
| struct DeviceProfileCallbackView: View { |
Contributor
There was a problem hiding this comment.
This is a nice doc for developers. I would suggest we do like this to all callback views.
| @@ -0,0 +1,150 @@ | |||
| // | |||
Contributor
There was a problem hiding this comment.
This file appears to be unused and could be removed.
| class AppDelegate: NSObject, UIApplicationDelegate, @preconcurrency UNUserNotificationCenterDelegate { | ||
|
|
||
| // MFA Clients | ||
| public var oathClient: OathClient? |
Contributor
There was a problem hiding this comment.
If we don’t plan to showcase registering OATH and PUSH mechanisms via Journey without QR code scanning, then those clients should be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sdks 4616 journey sample app
Adding a new sample app that demonstrates the use of the Ping SDKs 2.0 Journey module with SwuiftUI