fix: webauthn-loop #399
Merged
fix: webauthn-loop #399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cerebrl
reviewed
Dec 11, 2025
| form.submit(); | ||
| } | ||
| $: formMessageKey = convertStringToKey(form?.message); |
Contributor
There was a problem hiding this comment.
By separating this reactive block from the below reactive block, are we isolating formMessageKey changes from triggering a re-run of the reactive block below?
Contributor
Author
There was a problem hiding this comment.
Yes - perhaps it is overly defensive to do this, because the boolean should take care of it also but you are correct.
cerebrl
approved these changes
Jan 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in a reactive block that was causing an infinite loop eventually resulting in a failure in the webauthn flow.
https://pingidentity.atlassian.net/browse/SDKS-4482