Skip to content

Fix model selector scrolling and add search#3

Open
falfaddaghi wants to merge 1 commit intomainfrom
fix/model-select-scroll-and-search
Open

Fix model selector scrolling and add search#3
falfaddaghi wants to merge 1 commit intomainfrom
fix/model-select-scroll-and-search

Conversation

@falfaddaghi
Copy link
Copy Markdown
Member

Summary

  • fix broken scrolling in the model dropdown inside the floating workflow generator panel
  • add in-dropdown model search
  • add keyboard navigation with arrow keys, Enter, and Escape

Details

  • replace the nested Radix scroll area in the model selector with a native scroll container to prevent wheel/trackpad events from being hijacked by the parent panel
  • stop wheel propagation from the dropdown list
  • add a sticky search input that filters by provider/group label, display name, and raw provider/model value
  • auto-focus the search field when the dropdown opens
  • highlight and auto-scroll the active option during keyboard navigation

Validation

  • npx eslint src/nodes/shared/model-select.tsx

@Nasrallah-AL
Copy link
Copy Markdown
Collaborator

This MR will be merged once nexus-bridge-proxy is integrated. The integration is required to make model selection more accurate — currently it uses a generic selection, but the correct model varies depending on the CLI tool being used.

  • Model selection should reflect the active CLI tool, not a generic default
  • Blocked on: nexus-bridge-proxy integration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants