Skip to content

Comments

I completed the assignment, but pushed it to assignment-1 by mistake …#2

Open
Fooroogh-RM wants to merge 6 commits intomainfrom
assignment-2
Open

I completed the assignment, but pushed it to assignment-1 by mistake …#2
Fooroogh-RM wants to merge 6 commits intomainfrom
assignment-2

Conversation

@Fooroogh-RM
Copy link
Owner

@Fooroogh-RM Fooroogh-RM commented Dec 4, 2025

…first, I'm pushing it now to branch assignment-2.

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

I completed the assignment.

What did you learn from the changes you have made?

more of scikit

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

no

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

I accidentally pushed it to assignment-1 and then I made assignment-2 branch and pushed it here.

How were these changes tested?

on the VS

A reference to a related issue in your repository (if applicable)

Checklist

  • I can confirm that my changes are working as intended

…first, I'm pushing it now to branch assignment-2.
Copy link

@anjali-deshpande-hub anjali-deshpande-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following are the corrections required:

  1. Question (iv) How many predictor variables do we have (Hint: all variables other than mpg)?
    Please correct this answer.

  2. Question 4: The question is asking for Root mean square prediction error (also called RMSE) instead of percentage error.

You answer to Question 2 (ii) is correct. It represents the line of best fit, which is defined by the concept of linear regression.

@anjali-deshpande-hub
Copy link

A friendly reminder to complete the requested review changes. Thanks!

@Fooroogh-RM
Copy link
Owner Author

Fooroogh-RM commented Dec 11, 2025

Hi Anjali,
Thank you for pointing out he issues in my assignment. I think I was able to fix them.

Copy link

@anjali-deshpande-hub anjali-deshpande-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Fooroogh,
I noticed that you submitted two files assignment_2_frm.ipynb and assignment_2_frm_a2.ipynb
but neither contains the requested review changes. Please remember that it's unnecessary to change the filename when making review changes. Could you kindly upload a single corrected file named assignment_2.ipynb and remove the other two? If you need help with this, please join the work period where one of the LS staff can help
Thanks!

@Fooroogh-RM
Copy link
Owner Author

I pushed assignment-2. I can see the changes now. Could you please check to see if they reflected on your end, too? Thank you!

Copy link

@anjali-deshpande-hub anjali-deshpande-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am still unable to see the review changes in the file https://github.com/Fooroogh-RM/LCR/blob/assignment-2/assignment_2.ipynb Screenshot is attached
Screenshot 2025-12-27 160026

@Fooroogh-RM
Copy link
Owner Author

Fooroogh-RM commented Dec 28, 2025

I am still unable to see the review changes in the file https://github.com/Fooroogh-RM/LCR/blob/assignment-2/assignment_2.ipynb Screenshot is attached Screenshot 2025-12-27 160026

Hi Anjali,

The question is asking for RMSE, and I calculated RMSE. Could you please help me understand the issue?
Thank you!

@anjali-deshpande-hub
Copy link

Hello!
You have calculated 'Root Mean Square Percentage Error'. The question is asking for
RMSE which is an absolute error magnitude (same units as data) rather than relative (percentage) error. The correct answer is

rmse = np.sqrt(mean_squared_error(test_response, y_pred))

@anjali-deshpande-hub
Copy link

Please make the suggested changes. Thank you.

Copy link

@anjali-deshpande-hub anjali-deshpande-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All fixed now. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants