Skip to content

Statically compile type test for instance of operator #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bwrrp merged 1 commit into from
Dec 24, 2025
Merged

Statically compile type test for instance of operator #680

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/expressions/operators/types/InstanceOfOperator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ class InstanceOfOperator extends Expression {
) {
super(
expression.specificity,
[expression],
[expression, typeTest],
{ canBeStaticallyEvaluated: false },
false,
type,
Expand Down
18 changes: 15 additions & 3 deletions test/specs/parsing/operators/types/InstanceOfOperator.tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
import * as chai from 'chai';
import * as slimdom from 'slimdom';
import { Document } from 'slimdom';

import { evaluateXPathToBoolean } from 'fontoxpath';
import evaluateXPathToAsyncSingleton from 'test-helpers/evaluateXPathToAsyncSingleton';
import { Language, evaluateXPathToBoolean } from 'fontoxpath';

describe('instance of operator', () => {
it('returns true for a valid instance of xs:boolean', () =>
Expand Down Expand Up @@ -38,4 +37,17 @@ describe('instance of operator', () => {

it('returns false for an invalid instance of node()', () =>
chai.assert.isFalse(evaluateXPathToBoolean('1 instance of node()')));

it('keeps namespaces into account', () => {
chai.assert.isTrue(
evaluateXPathToBoolean(
`declare namespace x='x';
<x:ele/> instance of element(x:ele)`,
new Document(),
null,
null,
{ language: Language.XQUERY_3_1_LANGUAGE },
),
);
});
});
Loading