Fix handling of AST expressions in fontoxpath:evaluate error handling

[bwrrp]

Fixes #672

[bundlemon]

BundleMon

Unchanged files (2)

Status	Path	Size	Limits
✅	fontoxpath.esm.js	78.72KB	-
✅	fontoxpath.js	78.61KB	-

No change in files bundle size

Final result: ✅

View report in BundleMon website ➡️

---

Current branch size history | Target branch size history

[DrRataplan]

Kind of missing a unit test here. Can you add one?

[coveralls]

coverage: 91.576%. remained the same
when pulling 572aa37 on evaluate-error-element-expressions
into c5f6dd6 on master.

[bwrrp]

Kind of missing a unit test here. Can you add one?

Added one. Turns out this also only triggered if the evaluated expression was generated with stack traces on, as otherwise parseAndRethrowError would just hit its early return and ignore the selector argument.

[DrRataplan]

Oof. Hope at least the error is now kind-of readable?

[bwrrp]

Yep, full error thrown here is now:

1: fontoxpath:evaluate($expr, map{ 'n': 1.2 })
   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Inner error:
1: format-integer($n,"A")
   ^^^^^^^^^^^^^^^^^^^^^^
      
Error: XPTY0004 Unable to cast argument of type xs:decimal to type xs:integer? while calling format-integer
  at <functionCallExpr (format-integer)>:1:1 - 1:23
  at <functionCallExpr (fontoxpath:evaluate)>:1:1 - 1:44

Without the fix we get:

1: fontoxpath:evaluate($expr, map{ 'n': 1.2 })
   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

TypeError: undefined is not iterable (cannot read property Symbol(Symbol.iterator))
  at <functionCallExpr (fontoxpath:evaluate)>:1:1 - 1:44