Skip to content

start testing Enzyme#2392

Merged
CarloLucibello merged 9 commits intomasterfrom
cl/enzyme
Mar 20, 2024
Merged

start testing Enzyme#2392
CarloLucibello merged 9 commits intomasterfrom
cl/enzyme

Conversation

@CarloLucibello
Copy link
Copy Markdown
Member

@CarloLucibello CarloLucibello commented Mar 8, 2024

We don't officially support Enzyme yet, but since we are going to in the future we better start testing, see what is missing, and watch out for regressions.
The testing work has already started at EnzymeAD/Enzyme.jl#805, here I mostly copy some of the tests contributed by @jgreener64 so that they become part of Flux's testsuite.

Related issues in Enzyme.jl:

PRs in CUDA.jl:

Comment thread test/ext_enzyme/enzyme.jl Outdated
@CarloLucibello
Copy link
Copy Markdown
Member Author

if tests pass as they should this can be merged.

This PR gives us already some good cpu coverage. For CUDA instead, I get some pretty fundamental problems at the moment EnzymeAD/Enzyme.jl#1347. GPU tests will be added in future PRs

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.73%. Comparing base (5f84b68) to head (767349e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2392      +/-   ##
==========================================
+ Coverage   43.04%   45.73%   +2.68%     
==========================================
  Files          32       32              
  Lines        1856     1863       +7     
==========================================
+ Hits          799      852      +53     
+ Misses       1057     1011      -46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CarloLucibello
Copy link
Copy Markdown
Member Author

ready to merge

@CarloLucibello
Copy link
Copy Markdown
Member Author

bump

@CarloLucibello CarloLucibello merged commit 9b9f950 into master Mar 20, 2024
@mcabbott mcabbott deleted the cl/enzyme branch March 20, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants