Skip to content

make removing last satellite more robust #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ot-goegelem wants to merge 1 commit into
base: next
Choose a base branch
from
Open

make removing last satellite more robust #94

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions src/modules/util/CesiumCleanupHelper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,19 @@ export class CesiumCleanupHelper {
console.info("Removing leftover Cesium internal data");
onTickEventRemovalCallback();

const labelCollection = viewer.scene.primitives?._primitives[0]?._primitives[0]._primitives[0]._labelCollection;
if (labelCollection) {
labelCollection._spareBillboards.forEach((billboard) => {
labelCollection._billboardCollection.remove(billboard);
});
labelCollection._spareBillboards.length = 0;
try {
const primitives = viewer.scene.primitives?._primitives;
const labelCollection = primitives?.[0]?._primitives?.[0]?._primitives?.[0]?._labelCollection;
if (labelCollection && labelCollection._spareBillboards && labelCollection._billboardCollection) {
labelCollection._spareBillboards.forEach((billboard) => {
if (billboard) {
labelCollection._billboardCollection.remove(billboard);
}
});
labelCollection._spareBillboards.length = 0;
}
} catch (e) {
console.warn("CesiumCleanupHelper: Could not clean up internal data", e);
}
});
}
Expand Down