feat: extend DBFlexContextSchema validation to only allow valid units

documentation/changelog.rst

@@ -14,6 +14,7 @@ New features
 * Added form modal to edit an asset's ``flex_context`` [see `PR #1320 <https://github.com/FlexMeasures/flexmeasures/pull/1320>`_]
 * Better y-axis titles for charts that show multiple sensors with a shared unit [see `PR #1346 <https://github.com/FlexMeasures/flexmeasures/pull/1346>`_]
 * Add CLI command ``flexmeasures jobs save-last-failed`` for saving the last failed jobs [see `PR #1342 <https://www.github.com/FlexMeasures/flexmeasures/pull/1342>`_ and `PR #1359 <https://github.com/FlexMeasures/flexmeasures/pull/1359>`_]
+* Extended ``DBFlexContextSchema`` validation to include validation for units [see `PR #1364 <https://github.com/FlexMeasures/flexmeasures/pull/1364>`_]
 
 Infrastructure / Support
 ----------------------

flexmeasures/data/schemas/scheduling/__init__.py

@@ -19,7 +19,13 @@
 )
 from flexmeasures.data.schemas.utils import FMValidationError
 from flexmeasures.data.schemas.times import AwareDateTimeField, PlanningDurationField
-from flexmeasures.utils.unit_utils import ur, units_are_convertible
+from flexmeasures.utils.unit_utils import (
+    ur,
+    units_are_convertible,
+    is_energy_price_unit,
+    is_power_unit,
+    is_energy_unit,
+)
 
 
 class FlexContextSchema(Schema):
@@ -153,6 +159,8 @@ def check_prices(self, data: dict, **kwargs):
                     f"""Please switch to using `production-price: {{"sensor": {data[field_map["production-price-sensor"]].id}}}`."""
                 )
 
+        # make sure that the prices fields are valid price units
+
         # All prices must share the same unit
         data = self._try_to_convert_price_units(data)
 
@@ -224,7 +232,6 @@ def _get_variable_quantity_unit(
 
 
 class DBFlexContextSchema(FlexContextSchema):
-
     @validates_schema
     def forbid_time_series_specs(self, data: dict, **kwargs):
         """Do not allow time series specs for the flex-context fields saved in the db."""
@@ -260,6 +267,51 @@ def forbid_fixed_prices(self, data: dict, **kwargs):
                 "Fixed prices are not currently supported for production_price in flex-context fields in the DB."
             )
 
+    @validates_schema
+    def validate_fields_unit(self, data: dict, **kwargs):
+        """Check that each field value has a valid unit."""
+
+        self._validate_price_fields(data)
+        self._validate_power_fields(data)
+        self._validate_inflexible_device_sensors(data)
+
+    def _validate_price_fields(self, data: dict):
+        """Validate price fields."""
+        self._validate_fields(data, "price", is_energy_price_unit)
+
+    def _validate_power_fields(self, data: dict):
+        """Validate power fields."""
+        self._validate_fields(data, "power", is_power_unit)
+
+    def _validate_fields(self, data: dict, field_type: str, unit_validator):
+        """Validate fields based on type and unit validator."""
+        fields = [field for field in data if field_type in field]
+        for field in fields:
+            if field in data:
+                if isinstance(data[field], str):
+                    if not unit_validator(data[field]):
+                        raise ValidationError(
+                            f"{field_type.capitalize()} field '{field}' must be a {field_type} unit."
+                        )
+                elif isinstance(data[field], Sensor):
+                    if not unit_validator(data[field].unit):
+                        raise ValidationError(
+                            f"{field_type.capitalize()} field '{field}' must be a {field_type} unit."
+                        )
+                else:
+                    raise ValidationError(
+                        f"{field_type.capitalize()} field '{field}' must be a fixed value or sensor."
+                    )
+
+    def _validate_inflexible_device_sensors(self, data: dict):
+        """Validate inflexible device sensors."""
+        if "inflexible_device_sensors" in data:
+            for sensor in data["inflexible_device_sensors"]:
+                if not is_power_unit(sensor.unit) and not is_energy_unit(sensor.unit):
+                    raise ValidationError(
+                        f"Inflexible device sensor '{sensor.id}' must have a power or energy unit."
+                    )
+
 
 class MultiSensorFlexModelSchema(Schema):
     """