Skip to content

fix: change request navigation #6151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2025
Merged

fix: change request navigation #6151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions frontend/web/components/pages/ChangeRequestDetailPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ import DiffChangeRequest from 'components/diff/DiffChangeRequest'
import JSONReference from 'components/JSONReference'
import ErrorMessage from 'components/ErrorMessage'
import ConfigProvider from 'common/providers/ConfigProvider'
import { useHistory } from 'react-router-dom'

type ChangeRequestPageType = {
router: RouterChildContext['router']
match: {
params: {
environmentId: string
Expand All @@ -50,10 +50,8 @@ type ChangeRequestPageType = {
}
}

const ChangeRequestDetailPage: FC<ChangeRequestPageType> = ({
match,
router,
}) => {
const ChangeRequestDetailPage: FC<ChangeRequestPageType> = ({ match }) => {
const history = useHistory()
const { environmentId, id, projectId } = match.params
const [_, setUpdate] = useState(Date.now())
const error = ChangeRequestStore.error
Expand Down Expand Up @@ -145,7 +143,7 @@ const ChangeRequestDetailPage: FC<ChangeRequestPageType> = ({
destructive: true,
onYes: () => {
AppActions.deleteChangeRequest(id, () => {
router.history.replace(
history.replace(
`/project/${projectId}/environment/${environmentId}/change-requests`,
)
})
Expand All @@ -163,7 +161,7 @@ const ChangeRequestDetailPage: FC<ChangeRequestPageType> = ({
openModal(
'Edit Change Request',
<CreateFlagModal
history={router.history}
history={history}
environmentId={environmentId}
projectId={projectId}
changeRequest={changeRequest}
Expand Down
Loading