Skip to content

Conversation

@kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Sep 30, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Componentises feature table filters so that they can be reused between features, identity and future pages completely
  • Adds persistent URL filtering to identity page

How did you test this code?

Filter and sort on both the features page and an identity

@kyle-ssg kyle-ssg requested a review from a team as a code owner September 30, 2025 18:55
@kyle-ssg kyle-ssg requested review from Zaimwa9 and removed request for a team September 30, 2025 18:55
@vercel
Copy link

vercel bot commented Sep 30, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
flagsmith-frontend-preview Ready Ready Preview Comment Oct 28, 2025 10:30am
flagsmith-frontend-staging Ready Ready Preview Comment Oct 28, 2025 10:30am
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
docs Ignored Ignored Preview Oct 28, 2025 10:30am

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Sep 30, 2025
@kyle-ssg kyle-ssg changed the base branch from main to chore/componentise-feature-override-row September 30, 2025 18:55
@github-actions github-actions bot added the chore label Sep 30, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 30, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-6119 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-6119 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-6119 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-6119 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-6119 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-6119 Finished ✅ Results

cursor[bot]

This comment was marked as outdated.

Copy link
Contributor

@Zaimwa9 Zaimwa9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite minors one. I'll approve in case not using sort from url is by design otherwise this change and good to go.
Other are minors and ignorable

cursor[bot]

This comment was marked as outdated.

@kyle-ssg kyle-ssg merged commit 21697fe into chore/componentise-feature-override-row Oct 28, 2025
6 of 8 checks passed
@kyle-ssg kyle-ssg deleted the chore/componentise-feature-filters branch October 28, 2025 10:28
@github-actions github-actions bot added chore and removed chore labels Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants