fix: permissions not revoked after view project disabled #5438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
github-actions
bot
added
front-end
Docker builds report
|
Uffizzi Ephemeral Environment Deploying☁️ https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/5438 ⚙️ Updating now by workflow run 14928873199. What is Uffizzi? Learn more! |
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the issue where permissions are not being revoked after a view project is disabled by refactoring the permission lookup and toggle logic, and by improving user feedback during permission changes.
- Refactored the processResults logic by extracting separate functions for finding permissions by group, role, or user.
- Introduced a new RemoveViewPermissionModal component to confirm removal of view permissions and replaced direct tag query usage.
- Added a new utility function (capitalize) to standardize string capitalization and updated toast messages accordingly.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| frontend/web/components/EditPermissions.tsx | Refactored permission processing logic, updated permission toggle behavior to use a confirmation modal, and improved button state handling. |
| frontend/common/utils/utils.tsx | Added a new capitalize utility function to improve the consistency of string casing. |
Comments suppressed due to low confidence (1)
frontend/web/components/EditPermissions.tsx:985
- [nitpick] The onChange handler contains nested conditions for handling view permission toggling. Consider extracting this logic into a helper function to improve readability and maintainability.
if (level !== 'organisation' && p.key === viewPermission && hasPermission(viewPermission) && entityPermissions.permissions.length > 1) {
Co-authored-by: Copilot <[email protected]>
emyller
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #5432
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Changes
Ref: #5432
https://www.loom.com/share/a321aefb3f8d4298a181876f6b67baab?sid=f652b515-569d-4aee-a957-a93ebcd93466
Please describe.
How did you test this code?
Please describe.