WIP: async support #111
Closed
WIP: async support #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds async support to the python client.
Note that this is a draft at the moment, and takes the approach of simply replacing the current client with one that supports async. Probably to get this into a releasable state, we want to either create async / non-async methods on the client, or create 2 separate clients - an async and a non-async one.
This PR is also a breaking change, as it replaces the use of the
requestsmodule with thehttpxmodule. As such, we will no longer be able to support theRetryclass that is currently provided as an argument to the constructor.