-
Notifications
You must be signed in to change notification settings - Fork 9
Element SendKeys supports strings for different locales and non-US keaybords #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@aristotelos |
@aristotelos Added now also support for SendKeys with embedded actions and composite actions Added also some UITests with KendKeys embedded actions examples. |
@@ -218,7 +218,8 @@ public async Task<ActionResult> ElementSendKeys([FromRoute] string sessionId, [F | |||
|
|||
try | |||
{ | |||
await _actionsDispatcher.DispatchActionsForString(session, inputId, source, elementSendKeysRequest.Text); | |||
//await _actionsDispatcher.DispatchActionsForStringUsingFlaUICore(session, inputId, source, elementSendKeysRequest.Text); | |||
await _actionsDispatcher.DispatchSendKeysUsingFlaUICore(elementSendKeysRequest.Text); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really like having two branches of code for dispatching actions... Can't we replace the DispatchActionsForString
implementation?
There seems to be a conflict here between:
If that is the case, I would first like to have this raised for the WebDriver standard. @PiotrNestor have you tried that? If that attempt has been done and has proved unsuccessfully, we could make a conscious choice to deviate from it and document that very explicitly. |
@jensakejohansson
@hugoMeier
@aristotelos
@Roemer
@stevemonaco
@bmarroquin
The issue solves the issue as reported here:
#129
The updated implementation: Uses Flaui.Core.Input Keyboard.Type to handle the ElementSendKeys request.
The FlaUI.Core already handles many more characters in strings than the WebDriver does not.
It is possible that ElementSendKeys should handle many more string variants containing for example Selenium Keys.XXX but
Added also some UITests that confirm the updated functionality.
In general it's unclear what Selenium actions are supposed to work in SendKeys
In other words:
In the original implementation this does not work - select the first word in a input element and delete it:
this works in stead
Obviously the above is the same in this PR