Skip to content

#52 alert even if some requests fail #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gluckzhang merged 1 commit into from
Aug 27, 2025
Merged

#52 alert even if some requests fail #53

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions td2/provider-default.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ func (d *DefaultProvider) CheckIfValidatorVoted(ctx context.Context, proposalID
// If we've tried all nodes and found no votes, return false
// If there were errors, return the last one
if lastErr != nil {
return false, fmt.Errorf("failed to check validator vote across all nodes: %w", lastErr)
return false, fmt.Errorf("did not find validator vote transaction across all nodes, last error in a response: %w", lastErr)
}

return false, nil
Expand Down Expand Up @@ -158,7 +158,7 @@ func (d *DefaultProvider) QueryUnvotedOpenProposals(ctx context.Context) ([]gov.
l(fmt.Sprintf("⚠️ Error checking if validator voted: %v", err))
}

if err == nil && !hasVoted {
if !hasVoted {
unvotedProposals = append(unvotedProposals, proposal)
}
}
Expand Down
Loading