Restore the broken record layout optimization by gbak and extend it to the new datatypes #8815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… insist on it and prevent the engine from generating field IDs in a different order. This restores the original record layout optimization accidentally broken by my commit #2ed48a6.
Member
Author
|
Before this patch: After this patch: |
dyemanov
added a commit
that referenced
this pull request
Dec 3, 2025
…o the new datatypes (#8815) * Add new 128-bit types to the record layout optimization attempted by gbak * Given the backup file already contains fields in the optimized order, insist on it and prevent the engine from generating field IDs in a different order. This restores the original record layout optimization accidentally broken by my commit #2ed48a6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The order of field ID generation inside DFW is not reliable, because it joins two system tables and generally the retrieval order would depend on the query plan. The added
SORTED BYclause fixes it forCREATE/ALTER TABLE, but the resulting order does not match the order of insertions intoRDB$RELATION_FIELDSanymore. However, gbak does its best to optimize the record layout and it relies on the ID generation being performed in the storage order. Thus I moved the ID generation to the gbak side to ensure the record format is created with the expected (optimized) layout.