Add submodule support for Git stacks#1109
Draft
Westie wants to merge 10 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Marked as draft pending advice relating to creating Postgres migrations
Proposed change
Introduction
This PR adds in support for submodules within Git stacks.
I've created a new property for git repositories, called
submodulesEnabled.This property, if enabled, effectivelly calls the following commands upon syncing a git repository, syncing a git stack and deploying a git stack:
FYI I have checked, the
.gitfolder that belongs to the submodule is not copied across from the repository to the stack.Since deployments of stacks don't actually take git into consideration, all we need to do is actually ensure the submodule is properly set up - which this does to the best of its ability.
Closes #917
What it looks like
Type of change