You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thermo-nuclear review found two changes needed before this is merge-ready:
MenuCard.tsx currently fabricates reserve status with snap.reserveDescription ?? "Lasts until reset". That status is backend-owned and should only appear when the bridge/backend pace analysis provides it. Please omit the secondary status when reserveDescription is missing, or move this into a small view-model helper that preserves the backend contract.
The fallback reserve row is now gated by the weekly-window check. That hides valid backend-provided reservePercent / reserveDescription whenever timing metadata is incomplete. Explicit reserve metadata should render independently of whether the frontend can compute the new budget pills. The fallback should be closer to:
Suggested cleanup: extract a small getMetricPaceView(snap) / PaceBudgetSection boundary that returns exactly one of: computed budget, explicit reserve row, or nothing. That keeps backend reserve semantics intact and removes the competing ad-hoc conditions from MetricRow.
Thanks for adding the weekly on-pace usage budgets and for preserving the backend pace metadata semantics after review — merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #86
Testing
Preview
Default:

Expanded:
