Skip to content

feat: ci-3276 comparison and card #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
debugwand wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: ci-3276 comparison and card #127

debugwand wants to merge 1 commit into from

Conversation

@debugwand
Copy link
Contributor

@debugwand debugwand commented Nov 28, 2025

  • looking at spark I found that titles are optional, and within cards for both comparison and info box you can have either an imageset, a paragraph or both.

@debugwand debugwand requested review from a team as code owners November 28, 2025 14:05
@debugwand debugwand marked this pull request as draft December 2, 2025 15:02
@debugwand
Copy link
Contributor Author

debugwand commented Dec 2, 2025

moving into draft while we figure out what components can and cannot go into card, and why editorial are using comparison and infobox for things that aren't really semantically comparison and infoboxes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@umbobabo umbobabo umbobabo approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@debugwand @umbobabo