feat: use precompile for native payments and burn #207
+61
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This branch also has #206 because the fvm-solidity library currently requires 0.8.30. |
Kubuxu
reviewed
Oct 3, 2025
src/PDPVerifier.sol
Outdated
|
|
||
| // Decode and return the result | ||
| return abi.decode(result, (uint256)); | ||
| return epoch.getBeaconRandomness(); |
There was a problem hiding this comment.
I'm not a huge fan of augmenting uint256 like this. It makes the source of this less clear. It feels a touch too clever.
Kubuxu
reviewed
Oct 3, 2025
src/PDPVerifier.sol
Outdated
| function burnFee(uint256 amount) internal { | ||
| require(msg.value >= amount, "Incorrect fee amount"); | ||
| (bool success,) = BURN_ACTOR.call{value: amount}(""); | ||
| bool success = amount.burn(); |
There was a problem hiding this comment.
Same thing as with randomness, IM,O there is no harm in it being FVMPay.burn(amount) and it makes the code much more readable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer @ZenGround0
https://github.com/filecoin-project/fvm-solidity
I made this library to reuse the precompile code and its mocks across repositories, after demonstrating that the precompile native send method uses less gas.
See also the related filecoin-pay changeset: FilOzone/filecoin-pay#234
Changes