Skip to content

Fix: Prevent UI reset when new device inserted during write (#825) #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Prachi194agrawal wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Fix: Prevent UI reset when new device inserted during write (#825) #914

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6d76a24
Fix: Prevent UI reset when new device inserted during write (#825)
Prachi194agrawal Dec 16, 2025
f8cfe68
Refactor: Use state-based isBusy() instead of progress checking (#825)
Prachi194agrawal Jan 13, 2026
6d63fbc
Refactor: Move QProcess to base Drive class and remove m_isBusy flag
Prachi194agrawal Jan 14, 2026
9f5aa75
Refactor: Use std::unique_ptr for QProcess management
Prachi194agrawal Jan 15, 2026
3169c70
Address code review feedback: clean up RAII implementation
Prachi194agrawal Jan 15, 2026
f1972ee
Refactor QProcess management to use std::make_unique and remove platf…
Prachi194agrawal Jan 16, 2026
56c55a7
Fix: Revert to .reset() because make_unique is incompatible with cust…
Prachi194agrawal Jan 16, 2026
de28ba0
Fix: Apply clang-format to DriveOperationDeleter
Prachi194agrawal Jan 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 20 additions & 6 deletions src/app/drivemanager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,12 +157,26 @@ void DriveManager::onDriveConnected(Drive *d)
endInsertRows();
emit drivesChanged();

if (m_provider->initialized()) {
m_selectedIndex = position;
emit selectedChanged();
} else {
m_selectedIndex = 0;
emit selectedChanged();
// Fix for issue #825: Only change selection if the currently selected drive
// is not being written to or restored
bool currentDriveActive = false;
Drive *currentDrive = selected();
if (currentDrive && currentDrive->progress()) {
qreal progress = currentDrive->progress()->value();
qreal driveSize = currentDrive->size();
// Check if there's an active write or restore operation
currentDriveActive = (progress > 0 && progress < driveSize);
}

// Only auto-select the new drive if no operation is in progress
if (!currentDriveActive) {
if (m_provider->initialized()) {
m_selectedIndex = position;
emit selectedChanged();
} else {
m_selectedIndex = 0;
emit selectedChanged();
}
}

if (d->restoreStatus() == Drive::CONTAINS_LIVE) {
Expand Down