Added option to stop and resume download #732

gastoner · 2024-09-22T09:15:14Z

Closes #716

grulja · 2024-09-23T13:19:35Z

I feel like "pause" might be better wording for this case. Also, it should probably replace the "Cancel" button. Clicking on "Pause" would change the "Pause" button to "Cancel" and have "Resume" button to appear on the right side.

gastoner · 2024-10-02T18:16:31Z

@grulja Rebased after cleanup

grulja

You didn't rebase properly and this change includes one of my changes I pushed recently.

I'm still unsure how to integrate this functionality UI/UX wise. Maybe what I suggested is not the best approach.

Hi, @allanday, I know you are quite busy, but would you be able to suggest a way how to best integrate this functionality?

Possible options are:

As I suggested before, replace "Cancel" button with "Pause" when downloading, which will pause it and change the button to "Cancel" once paused. It will also make "Resume" button to appear on the right side.
Keep "Cancel" button, but add a new option into the cancel dialog allowing you not to only cancel the whole process, but only pause it.
Keep it as it is UI-wise, but once user confirms cancellation in the cancel dialog, do not return to the main page, but keep it on the same downloading page and make "Resume" or "Retry" button available to restart the process.

grulja · 2024-10-04T07:50:15Z

src/app/downloadmanager.cpp

    }
 }

+void DownloadManager::stopDownload()


This basically duplicates DownloadManager::cancel()

gastoner

With this PR:

Screencast_20251205_133248.webm

grulja · 2025-12-05T12:40:28Z

With this PR:
Screencast_20251205_133248.webm

Why, when you pause downloading, it asks whether you want to cancel verification?

Signed-off-by: Evzen Gasta <[email protected]>

gastoner · 2025-12-05T14:33:08Z

@grulja Should now display correct info

grulja

I made Gemini my UX expert and the suggestion here is this layout:

________________________________________________________________________
|                          Downloading Fedora                          |
|                                                                      |
|            [████████████████████░░░░░░░░░░░░]  60%                   |
|                                                                      |
|                                                                      |
|   [ Cancel ]                                          [ Pause ]      |
|______________________________________________________________________|

With Pause changing to Resume once pressed.

I'm sorry for the extra work you have to do to keep switching from one solution to other.

Also the state you use should be Paused and not Stopped.

Signed-off-by: Evzen Gasta <[email protected]>

grulja

Btw. is there a way to maybe make the progress bar "grey" like inactive once the downloading is paused? The base Item QML object has https://doc.qt.io/qt-6/qml-qtquick-item.html#enabled-prop, but I'm not sure whether it has any visual implication in this case.

grulja · 2026-01-14T15:02:27Z

src/app/qml/DownloadPage.qml


    nextButtonVisible: {
-        if (currentStatus == Units.DownloadStatus.Finished)
+        // This will be [Finish] or [Resume] button to finish download or resume download 


Don't you mean [Resume] and [Pause]? Also, in case of the verification, I don't think there is a sensible action besides [Cancel] to do here.

grulja · 2026-01-14T15:09:10Z

src/app/qml/DownloadPage.qml

        else if (currentStatus === Units.DownloadStatus.Ready)
            qsTr("Ready to write %1").arg(file)
+        else if (currentStatus === Units.DownloadStatus.Paused)
+            qsTr("%1 has been paused").arg(file)


I think, following UX advice from Gemini, the main text should remain unchanged, but we should change the text below:

________________________________________________________________________ | [Illustration stops/dims] | | | | Downloading Fedora Workstation 43 | | Paused (2.3 GB left) | | | | [▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒░░░░░░░░░░░░░░░░░░░░░░░] | | | | [ Cancel ] [ RESUME ] | |______________________________________________________________________|

grulja · 2026-01-14T15:10:41Z

src/app/qml/DownloadPage.qml

+        else if (releases.variant.status === Units.DownloadStatus.Paused)
+            return qsTr("Resume")
+        else if (releases.variant.status === Units.DownloadStatus.Downloading ||
+                releases.variant.status === Units.DownloadStatus.Download_Verifying)


Again, I don't think we should allow to stop the verification process, not sure there is a point doing so.

grulja · 2026-01-14T15:11:00Z

src/app/qml/DownloadPage.qml

+                drives.selected.write(releases.variant)
+            }
+        } else if (releases.variant.status === Units.DownloadStatus.Downloading || 
+                   releases.variant.status === Units.DownloadStatus.Download_Verifying) {


grulja · 2026-01-14T15:12:04Z

src/app/releasemanager.h

                                      tr("Downloading"),
                                      tr("Checking the download"),
                                      tr("Ready to write"),
+                                      tr("Download has been paused"),


With what I said above, that it still can keep saying "Downloading ..." we might not need this status information.

grulja · 2026-01-14T15:13:36Z

src/app/qml/DownloadPage.qml

            wrapMode: QQC2.Label.Wrap
        }

+        QQC2.Label {


I wouldn't also add this info text.

Signed-off-by: Evzen Gasta <[email protected]>

Copilot

Pull request overview

This pull request adds pause and resume functionality for downloads in the Fedora Media Writer application. When a download is in progress, users can now pause it and resume later, with the download continuing from where it left off.

Changes:

Added new PAUSED status to the ReleaseVariant status enum
Made setStatus() a public slot to allow QML code to set the status to PAUSED
Updated UI to show appropriate buttons and messages for the paused state

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
src/app/releasemanager.h	Added PAUSED status enum value and corresponding status string, moved setStatus from private to public slots
src/app/qml/Units.qml	Added Paused enum value to QML status enumeration
src/app/qml/DownloadPage.qml	Implemented pause/resume UI logic with button state management and handlers
src/app/qml/CancelDialog.qml	Extended cancel dialog to handle the PAUSED state

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-21T20:39:42Z

src/app/qml/DownloadPage.qml

+        // This will be [Resume] or [Pause] button to finish download or resume download 
+        if (currentStatus == Units.DownloadStatus.Finished || 
+            currentStatus == Units.DownloadStatus.Paused || 
+            currentStatus == Units.DownloadStatus.Downloading)
            return true


The comment states "This will be [Resume] or [Pause] button to finish download or resume download" but the logic includes FINISHED status which doesn't align with pause/resume functionality. The FINISHED status check should be kept separate with its own comment for clarity.

Suggested change

// This will be [Resume] or [Pause] button to finish download or resume download

if (currentStatus == Units.DownloadStatus.Finished ||

currentStatus == Units.DownloadStatus.Paused ||

currentStatus == Units.DownloadStatus.Downloading)

return true

// This will be [Finish] button once the download and write process is completed

if (currentStatus == Units.DownloadStatus.Finished)

return true

// This will be [Resume] or [Pause] button to resume or temporarily stop an in-progress download

else if (currentStatus == Units.DownloadStatus.Paused ||

currentStatus == Units.DownloadStatus.Downloading)

return true

Copilot · 2026-01-21T20:39:43Z

src/app/qml/DownloadPage.qml

+    previousButtonText: {
+        return qsTr("Cancel")
+    }


The previousButtonText is wrapped in a function that simply returns a constant string. This can be simplified to just assign the string directly without a function wrapper.

Suggested change

previousButtonText: {

return qsTr("Cancel")

}

previousButtonText: qsTr("Cancel")

Copilot · 2026-01-21T20:39:43Z

src/app/qml/DownloadPage.qml

+            if (selectedOption != Units.MainSelect.Write) 
+                releases.variant.download()
+            if (drives.length) {
+                drives.selected.setImage(releases.variant)
+                drives.selected.write(releases.variant)
+            }


When resuming from a paused state, the code attempts to write to a drive even if the download hasn't completed yet. The resume logic should first complete the download before attempting to write. The current implementation will call both download() and write() simultaneously, which could cause unexpected behavior. Consider only calling download() when resuming from PAUSED status, and let the normal flow handle writing once the download is complete and the status becomes READY.

Suggested change

if (selectedOption != Units.MainSelect.Write)

releases.variant.download()

if (drives.length) {

drives.selected.setImage(releases.variant)

drives.selected.write(releases.variant)

}

if (selectedOption != Units.MainSelect.Write)

releases.variant.download()

// When resuming from Paused, only resume download.

// Writing will be handled by the normal flow once status is Ready.

gastoner requested a review from grulja September 22, 2024 09:16

gastoner force-pushed the allow_pausing_iso_automatic_download branch from 0cb8b13 to e9202a5 Compare September 23, 2024 17:16

gastoner force-pushed the allow_pausing_iso_automatic_download branch from e9202a5 to 111c84a Compare October 2, 2024 18:15

grulja requested changes Oct 4, 2024

View reviewed changes

rahmani3101 approved these changes Feb 26, 2025

View reviewed changes

gastoner force-pushed the allow_pausing_iso_automatic_download branch 4 times, most recently from 7fb3b6a to 1df4b49 Compare November 10, 2025 07:22

gastoner requested a review from grulja November 10, 2025 07:22

gastoner commented Dec 5, 2025

View reviewed changes

feat: added option to stop and resume download

63fafc4

Signed-off-by: Evzen Gasta <[email protected]>

gastoner force-pushed the allow_pausing_iso_automatic_download branch from 1df4b49 to 63fafc4 Compare December 5, 2025 14:32

grulja requested changes Jan 13, 2026

View reviewed changes

chore: updated pause and resume buton behavior

4f6f893

Signed-off-by: Evzen Gasta <[email protected]>

gastoner requested a review from grulja January 13, 2026 19:31

grulja requested changes Jan 14, 2026

View reviewed changes

chore: applied suggestions

7902237

Signed-off-by: Evzen Gasta <[email protected]>

gastoner requested review from Copilot and grulja January 21, 2026 20:19

Copilot started reviewing on behalf of gastoner January 21, 2026 20:34 View session

Copilot AI reviewed Jan 21, 2026

View reviewed changes

Added option to stop and resume download #732

Are you sure you want to change the base?

Added option to stop and resume download #732

Uh oh!

Conversation

gastoner commented Sep 22, 2024

Uh oh!

grulja commented Sep 23, 2024

Uh oh!

gastoner commented Oct 2, 2024

Uh oh!

grulja left a comment

Choose a reason for hiding this comment

Uh oh!

grulja Oct 4, 2024

Choose a reason for hiding this comment

Uh oh!

gastoner left a comment

Choose a reason for hiding this comment

Uh oh!

grulja commented Dec 5, 2025

Uh oh!

gastoner commented Dec 5, 2025

Uh oh!

grulja left a comment

Choose a reason for hiding this comment

Uh oh!

grulja left a comment

Choose a reason for hiding this comment

Uh oh!

grulja Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

grulja Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

grulja Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

grulja Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

grulja Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

grulja Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants