chore: commit Cargo.lock and enforce locked CI builds#147
Merged
Conversation
|
@Jayydy Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary
Commits
contracts/Cargo.lockto version control and updates CI to use--lockedbuilds, ensuring reproducible dependency resolution for thetoken-factory Soroban contract.
Changes
contracts/Cargo.lock— generated and added to the repository.github/workflows/wasm-build.yml— added--lockedflag to thecargo buildstepWhy
The token-factory contract is a deployable binary artifact (
cdylib).Per Rust best practices, application/binary crates should commit their
Cargo.lockso every build — local or CI — resolves the exact samedependency versions. Without
--locked, CI could silently pick upnewer patch versions that differ from what was tested locally.
Verification
git check-ignore -v contracts/Cargo.lockexits non-zero (file is not ignored)contracts/Cargo.lockis present and trackedcargo build --lockedwill fail fast if the lockfile is evermissing or out of sync with
Cargo.toml.
Related Issue
Link the issue using "Closes #XX" or "Fixes #XX".
Closes #84
Type of Change
Please tick the relevant options:
Testing Done
Please describe the tests you ran (unit tests, manual verification, etc.) to verify your changes.
Checklist