treat Option as CollectionLike in ScalaObjectMapper #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will ensure that the custom OptionDeserializer is always used when deserializing Options. Right now when `List[Option[_]]` is deserialized, the Option class is treated as a "simple" type in the constructed `JavaType` and thus a generic JSON Deserializer is used rather than `OptionDeserializer`. Note that the new test will NOT pass until a jackson-databind dependency with FasterXML/jackson-databind#407 is used
|
@christophercurrie now that we have a CLA and merged issue 407 (for master), should be possible to proceed with this one. |
|
Ah. Right, I forgot that this was submitted to mainline, and no merging back to 2.3... :-( |
|
My bad guys, wasn't aware. Perhaps some PR best practices should be added to to the main repo? |
|
@cowtowncoder is this change released in a version? |
|
@arschles I'll defer to @christophercurrie on that question; 2.4.0 of scala module is not out yet. |
|
k, thanks |
|
It should go out with 2.4; that's been delayed by personal time constraints but the target is to get it out by the end of next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will ensure that the custom OptionDeserializer is always used when deserializing Options.
Right now when
List[Option[_]]is deserialized, the Option class is treated as a "simple" type in the constructedJavaTypeand thus a generic JSON Deserializer is used rather thanOptionDeserializer.Note that the new test will NOT pass until a jackson-databind dependency with FasterXML/jackson-databind#407 is used