Skip to content

Conversation

k163377
Copy link
Contributor

@k163377 k163377 commented Jul 14, 2024

Optimize the search process for creators.
This improves first-time processing performance and memory usage since it is no longer necessary to check for the existence of other JsonCreator on the class.
It also solves the problem of findCreatorAnnotation results by AnnotationIntrospector registered by the user being ignored depending on the order in which modules are registered.

Fixes #805.

@k163377
Copy link
Contributor Author

k163377 commented Jul 14, 2024

The following issues must be resolved before merging
FasterXML/jackson-databind#4620

@k163377 k163377 changed the title Feat/creator Optimize the search process for creators Jul 14, 2024
@cowtowncoder
Copy link
Member

Databind#4620 fixed, will re-run tests.

@cowtowncoder
Copy link
Member

@k163377 Looks good, all tests now pass it looks like.

@k163377 k163377 marked this pull request as ready for review July 17, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

See if there is benefit from integrating with jackson-databind better wrt detecting "default" Constructor for Kotlin (data) classes
2 participants