Skip to content

Changed to not cache valueParameters #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Changed to not cache valueParameters #629

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/main/kotlin/com/fasterxml/jackson/module/kotlin/ValueCreator.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,10 @@ internal sealed class ValueCreator<T> {
/**
* ValueParameters of the KFunction to be called.
*/
val valueParameters: List<KParameter> by lazy { callable.valueParameters }
// If this result is cached, it will coexist with the SoftReference managed value in kotlin-reflect,
// and there is a risk of doubling the memory consumption, so it should not be cached.
// @see #584
val valueParameters: List<KParameter> get() = callable.valueParameters

/**
* Checking process to see if access from context is possible.
Expand Down