Skip to content

Increase deprecation level of NewStrictNullChecks due to version upgrade #1077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
k163377 merged 3 commits into from
Dec 6, 2025
Merged

Increase deprecation level of NewStrictNullChecks due to version upgrade #1077

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fca929d
Increase deprecation level due to version upgrade
k163377 Dec 6, 2025
1a99fe5
Suppression of deprecation error
k163377 Dec 6, 2025
09711a7
Update release notes wrt #1077
k163377 Dec 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions release-notes/CREDITS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,11 @@ Authors:

Contributors:

# 3.1.0 (not yet released)

WrongWrong (@k163377)
* #1077: Increase deprecation level of NewStrictNullChecks due to version upgrade

# 3.0.0-rc5 (not yet released)

WrongWrong (@k163377)
Expand Down
5 changes: 5 additions & 0 deletions release-notes/VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,11 @@ Former maintainers:
=== Releases ===
------------------------------------------------------------------------

3.1.0 (not yet released)

WrongWrong (@k163377)
#1077: Increase deprecation level of NewStrictNullChecks due to version upgrade

3.0.3 (28-Nov-2025)
3.0.2 (07-Nov-2025)
3.0.1 (21-Oct-2025)
Expand Down
2 changes: 1 addition & 1 deletion src/main/kotlin/tools/jackson/module/kotlin/KotlinFeature.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ enum class KotlinFeature(internal val enabledByDefault: Boolean) {
* Also, specifying both this and [StrictNullChecks] is not permitted.
*/
@Deprecated(
level = DeprecationLevel.WARNING,
level = DeprecationLevel.ERROR,
message = "This option will be merged into StrictNullChecks in 3.2.",
replaceWith = ReplaceWith("StrictNullChecks")
)
Expand Down
2 changes: 2 additions & 0 deletions src/main/kotlin/tools/jackson/module/kotlin/KotlinModule.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ class KotlinModule private constructor(
strictNullChecks: Boolean = StrictNullChecks.enabledByDefault,
val kotlinPropertyNameAsImplicitName: Boolean = KotlinPropertyNameAsImplicitName.enabledByDefault,
val useJavaDurationConversion: Boolean = UseJavaDurationConversion.enabledByDefault,
@Suppress("DEPRECATION_ERROR")
newStrictNullChecks: Boolean = NewStrictNullChecks.enabledByDefault,
) : SimpleModule(KotlinModule::class.java.name, PackageVersion.VERSION) {
// To reduce the amount of destructive changes, no properties will be added to the public.
Expand Down Expand Up @@ -70,6 +71,7 @@ class KotlinModule private constructor(
builder.isEnabled(StrictNullChecks),
builder.isEnabled(KotlinPropertyNameAsImplicitName),
builder.isEnabled(UseJavaDurationConversion),
@Suppress("DEPRECATION_ERROR")
builder.isEnabled(NewStrictNullChecks),
)

Expand Down
1 change: 0 additions & 1 deletion src/test/kotlin/tools/jackson/module/kotlin/DslTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import org.junit.jupiter.api.Assertions.assertNotNull
import org.junit.jupiter.api.Test
import tools.jackson.core.json.JsonReadFeature
import tools.jackson.core.json.JsonWriteFeature
import tools.jackson.module.kotlin.KotlinFeature.NewStrictNullChecks
import tools.jackson.module.kotlin.KotlinFeature.NullIsSameAsDefault
import tools.jackson.module.kotlin.KotlinFeature.NullToEmptyCollection
import tools.jackson.module.kotlin.KotlinFeature.NullToEmptyMap
Expand Down
2 changes: 2 additions & 0 deletions src/test/kotlin/tools/jackson/module/kotlin/KotlinModuleTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ class KotlinModuleTest {
fun strictNullChecksTests() {
assertTrue(
kotlinModule {
@Suppress("DEPRECATION_ERROR")
disable(NewStrictNullChecks)
enable(StrictNullChecks)
}.strictNullChecks
Expand All @@ -31,6 +32,7 @@ class KotlinModuleTest {
assertThrows<IllegalArgumentException> {
kotlinModule {
enable(StrictNullChecks)
@Suppress("DEPRECATION_ERROR")
enable(NewStrictNullChecks)
}
}
Expand Down