[Jackson 3] Fix #3580 Enum (de)serialization in conjunction with JsonFormat.Shape.NUMBER_INT
#5338
Conversation
|
@JooHyukKim This seems incomplete? Or maybe diff is missing something due to conflict? |
|
@cowtowncoder Yes, there were some other commits on same file, affecting this PR. THankss |
|
Ready for review! Just in case I wasn't clear enough |
src/main/java/tools/jackson/databind/deser/jdk/EnumDeserializer.java
Outdated
Show resolved
Hide resolved
src/main/java/tools/jackson/databind/deser/jdk/EnumDeserializer.java
Outdated
Show resolved
Hide resolved
| */ | ||
| protected final boolean _isShapeNumberInt; | ||
|
|
||
| public EnumDeserializer(EnumResolver byNameResolver, boolean caseInsensitive, |
There was a problem hiding this comment.
Need to start deprecating methods, adding overloads (since it's 3.1, not 3.0)
src/main/java/tools/jackson/databind/deser/BasicDeserializerFactory.java
Outdated
Show resolved
Hide resolved
| for (int i = enumConstants.length; --i >= 0; ) { // from last to first, so that in case of duplicate values, first wins | ||
| Enum<?> en = enumConstants[i]; | ||
| try { | ||
| Object o = accessor.getValue(en); |
There was a problem hiding this comment.
What is being accessed here?
There was a problem hiding this comment.
Value returned from method annotated with @JsonValue.
What could be a good improvement here?
There was a problem hiding this comment.
Hmmh. Maybe explain calling @JsonValue annotated accessor (Field/Method) on every enum entry?
|
Thank you for the review @cowtowncoder ! |
|
I re-examined paths before adding more JavaDoc, it just works without any additional implementation 🤔. |
|
Closing in favor of #5376 |
2 participants
No description provided.