move lock in DeserializerCache to before the try block

[pjfanning]

• see latest comments in Use ReentrantLock instead of synchronized in DeserializerCache to avoid deadlock on pinning #4430 - eg Use ReentrantLock instead of synchronized in DeserializerCache to avoid deadlock on pinning #4430 (comment)
• this change is more correct - if the lock call fails, we don't want the finally to try to release the lock
• it could also allow the underlying issue to bubble up, the failure to release the lock may be reported but we need to see the stack trace from the failure to acquire the lock (if that is what is happening - but it appears likely that it is.

[cowtowncoder]

Makes sense. OTOH, almost tempted to revert original change from 2.17, re-do for 2.18.

In hindsight should probably should have heeded my own warnings and NOT merge #4430 in a patch.

[JooHyukKim]

Just in case, could you test with this branch version? @wdallastella

[cowtowncoder]

I'll merge this first, forward, and then consider revert just in 2.17 (but move this forward to 2.18).

[cowtowncoder]

Looks like locking statement was already outside try-catch block for 2.18.

[wdallastella]

Just in case, could you test with this branch version? @wdallastella

@JooHyukKim just tested and worked fine.

[JooHyukKim]

Thank you for the report @wdallastella !